Github user hyunsik commented on the pull request:

    https://github.com/apache/tajo/pull/422#issuecomment-99991148
  
    The main cause is that my patch does not support direct projection of 
record type. In other words, the current work only support projecting primitive 
type fields in nested records. I'll support this feature and flatten operator 
in another jira issue. Now, I added logical planner to prohibit the direct 
projection of record type.
    
    ---
    
    
    
    
    
    
<sup>**[tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/SeqScanExec.java,
 line 198 
\[r6\]](https://reviewable.io:443/reviews/apache/tajo/422#-Jo8-AMBbSEZOQS3d0Cy-r6-198)**
 ([raw 
file](https://github.com/apache/tajo/blob/c5263f4e276abe3e42dbf99bf9dd87e142f67539/tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/SeqScanExec.java#L198)):</sup>
    This was investigated at https://issues.apache.org/jira/browse/TAJO-1422. 
So, I'll remove this TODO comment.
    
    ---
    
    
<sup>**[tajo-plan/src/main/java/org/apache/tajo/plan/nameresolver/NameResolver.java,
 line 56 
\[r6\]](https://reviewable.io:443/reviews/apache/tajo/422#-Jo8-AME6RwC628sqVQV-r6-56)**
 ([raw 
file](https://github.com/apache/tajo/blob/c5263f4e276abe3e42dbf99bf9dd87e142f67539/tajo-plan/src/main/java/org/apache/tajo/plan/nameresolver/NameResolver.java#L56)):</sup>
    LogicalPreProcessor and LogicalPlanner changes all column names derived 
from relations are full qualified names. LogicalPlanner temporarily makes some 
short names during processing. So, the situation you mentioned won't occur in 
the current planner. 
    
    ---
    
    
<sup>**[tajo-plan/src/main/java/org/apache/tajo/plan/nameresolver/NameResolver.java,
 line 104 
\[r6\]](https://reviewable.io:443/reviews/apache/tajo/422#-Jo8-AME6RwC628sqVQV-r6-104)**
 ([raw 
file](https://github.com/apache/tajo/blob/c5263f4e276abe3e42dbf99bf9dd87e142f67539/tajo-plan/src/main/java/org/apache/tajo/plan/nameresolver/NameResolver.java#L104)):</sup>
    Done.
    
    ---
    
    
<sup>**[tajo-plan/src/main/java/org/apache/tajo/plan/nameresolver/NameResolver.java,
 line 223 
\[r6\]](https://reviewable.io:443/reviews/apache/tajo/422#-Jo8-AME6RwC628sqVQV-r6-223)**
 ([raw 
file](https://github.com/apache/tajo/blob/c5263f4e276abe3e42dbf99bf9dd87e142f67539/tajo-plan/src/main/java/org/apache/tajo/plan/nameresolver/NameResolver.java#L223)):</sup>
    This is only for developers misuse instead of users.
    
    ---
    
    
    Comments from the [review on 
Reviewable.io](https://reviewable.io:443/reviews/apache/tajo/422)
    <!-- Sent from Reviewable.io -->



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to