[ 
https://issues.apache.org/jira/browse/TAJO-1598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14537961#comment-14537961
 ] 

ASF GitHub Bot commented on TAJO-1598:
--------------------------------------

GitHub user charsyam opened a pull request:

    https://github.com/apache/tajo/pull/565

    TAJO-1598 TableMeta should change equals mechanism

    In TableMeta equals, it compares Proto Data.
    but TableMetaProto has params as KeyValueSetProto. 
    It has a KeyValue Data as List.
    but it can cause comparison error. becuase list type compare items' order 
and value. but we should compare params like map.
    so this patch change compare machanism. compare storeType and Options

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/charsyam/tajo 
feature/fix_option_creation_order

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tajo/pull/565.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #565
    
----
commit 3a75ec45946ed2b5e3c1941405da313b379012a2
Author: clark.kang <[email protected]>
Date:   2015-05-10T14:48:19Z

    feature/fix_option_creation_order
    
    restore protected to private
    
    change TableMeta equals code

----


> TableMeta should change equals mechanism 
> -----------------------------------------
>
>                 Key: TAJO-1598
>                 URL: https://issues.apache.org/jira/browse/TAJO-1598
>             Project: Tajo
>          Issue Type: Bug
>            Reporter: DaeMyung Kang
>            Assignee: DaeMyung Kang
>
> In TableMeta equals, it compares Proto Data.
> but TableMetaProto has params as KeyValueSetProto. 
> It has a KeyValue Data as List.
> but it can cause comparison error. becuase list type compare items' order and 
> value. but we should compare params like map.
> so this patch change compare machanism. compare storeType and Options



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to