[
https://issues.apache.org/jira/browse/TAJO-1542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14541562#comment-14541562
]
ASF GitHub Bot commented on TAJO-1542:
--------------------------------------
Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/529#discussion_r30209355
--- Diff:
tajo-core/src/main/java/org/apache/tajo/engine/planner/PhysicalPlannerImpl.java
---
@@ -464,14 +464,14 @@ private PhysicalExec
createLeftOuterJoinPlan(TaskAttemptContext context, JoinNod
case IN_MEMORY_HASH_JOIN:
LOG.info("Left Outer Join (" + plan.getPID() +") chooses [Hash
Join].");
return new HashLeftOuterJoinExec(context, plan, leftExec,
rightExec);
- case NESTED_LOOP_JOIN:
- //the right operand is too large, so we opt for NL
implementation of left outer join
- LOG.info("Left Outer Join (" + plan.getPID() +") chooses [Nested
Loop Join].");
- return new NLLeftOuterJoinExec(context, plan, leftExec,
rightExec);
+ case MERGE_JOIN:
--- End diff --
Good job. It should have removed earlier.
> Refactoring of HashJoinExecs
> ----------------------------
>
> Key: TAJO-1542
> URL: https://issues.apache.org/jira/browse/TAJO-1542
> Project: Tajo
> Issue Type: Improvement
> Reporter: Navis
> Assignee: Navis
>
> It's not in condition to make some improvements. No offense.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
