[ 
https://issues.apache.org/jira/browse/TAJO-1603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14544934#comment-14544934
 ] 

Tajo QA commented on TAJO-1603:
-------------------------------

{color:red}*-1 overall.*{color}  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12733062/TAJO-1603.patch
  against master revision release-0.9.0-rc0-299-g36a703c.

    {color:green}+1 @author.{color}  The patch does not contain any @author 
tags.

    {color:green}+1 tests included.{color}  The patch appears to include 34 new 
or modified test files.

    {color:green}+1 javac.{color}  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc.{color}  The applied patch does not increase the 
total number of javadoc warnings.

    {color:green}+1 checkstyle.{color}  The patch generated 0 code style errors.

    {color:red}-1 findbugs.{color}  The patch appears to introduce 9 new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit.{color}  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests.{color}  The patch passed unit tests in 
tajo-core tajo-storage/tajo-storage-common tajo-storage/tajo-storage-hbase 
tajo-storage/tajo-storage-hdfs.

Test results: 
https://builds.apache.org/job/PreCommit-TAJO-Build/788//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-TAJO-Build/788//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-storage-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-TAJO-Build/788//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-storage-hbase.html
Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/788//console

This message is automatically generated.

> Refactor StorageManager
> -----------------------
>
>                 Key: TAJO-1603
>                 URL: https://issues.apache.org/jira/browse/TAJO-1603
>             Project: Tajo
>          Issue Type: Sub-task
>          Components: storage
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>            Priority: Minor
>             Fix For: 0.11.0
>
>         Attachments: TAJO-1603.patch
>
>
> This patch refactors StorageManager. Especially, it apparently separates 
> multiple roles into different classes. 
> * Static methods which handle registered store types are moved to 
> TableSpaceManager. 
> * All methods related for file store types are moved to FileStorageManager.
> * I created TableSpace, an interface for tablespace and I modified 
> StorageManager to inherit TableSpace.
>  * Later, StorageManager will be changed to AbstractTableSpace.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to