Github user jihoonson commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/602#discussion_r32792850
  
    --- Diff: 
tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/TableSpaceManager.java
 ---
    @@ -19,236 +19,372 @@
     package org.apache.tajo.storage;
     
     import com.google.common.annotations.VisibleForTesting;
    +import com.google.common.base.Optional;
    +import com.google.common.base.Preconditions;
     import com.google.common.collect.Maps;
    -import org.apache.hadoop.conf.Configuration;
    -import org.apache.hadoop.fs.FileSystem;
    +import net.minidev.json.JSONObject;
    +import net.minidev.json.parser.JSONParser;
    +import net.minidev.json.parser.ParseException;
    +import org.apache.commons.logging.Log;
    +import org.apache.commons.logging.LogFactory;
     import org.apache.hadoop.fs.Path;
    -import org.apache.tajo.TaskAttemptId;
    -import org.apache.tajo.catalog.Schema;
    -import org.apache.tajo.catalog.TableMeta;
    +import org.apache.tajo.TajoConstants;
     import org.apache.tajo.conf.TajoConf;
     import org.apache.tajo.storage.fragment.Fragment;
    +import org.apache.tajo.util.FileUtil;
    +import org.apache.tajo.util.Pair;
     
    +import javax.annotation.Nullable;
     import java.io.IOException;
     import java.lang.reflect.Constructor;
    +import java.net.URI;
     import java.util.Map;
    -import java.util.concurrent.ConcurrentHashMap;
    +import java.util.TreeMap;
    +import java.util.UUID;
    +
    +import static org.apache.tajo.storage.StorageConstants.LOCAL_FS_URI;
     
     /**
      * It handles available table spaces and cache TableSpace instances.
    + *
    + * Default tablespace must be a filesystem-based one.
    + * HDFS and S3 can be a default tablespace if a Tajo cluster is in fully 
distributed mode.
    + * Local file system can be a default tablespace if a Tajo cluster runs on 
a single machine.
    --- End diff --
    
    This explanation still looks good, but it will be nice if you list 
properties that the storage of default tablespace must have.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to