[ 
https://issues.apache.org/jira/browse/TAJO-1616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14598013#comment-14598013
 ] 

ASF GitHub Bot commented on TAJO-1616:
--------------------------------------

Github user hyunsik commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/602#discussion_r33068368
  
    --- Diff: 
tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/InsertRowExec.java
 ---
    @@ -0,0 +1,107 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.tajo.engine.planner.physical;
    +
    +import org.apache.commons.logging.Log;
    +import org.apache.commons.logging.LogFactory;
    +import org.apache.tajo.catalog.CatalogUtil;
    +import org.apache.tajo.catalog.TableMeta;
    +import org.apache.tajo.catalog.statistics.StatisticsUtil;
    +import org.apache.tajo.catalog.statistics.TableStats;
    +import org.apache.tajo.plan.logical.PersistentStoreNode;
    +import org.apache.tajo.plan.logical.StoreTableNode;
    +import org.apache.tajo.storage.Appender;
    +import org.apache.tajo.storage.TablespaceManager;
    +import org.apache.tajo.storage.Tuple;
    +import org.apache.tajo.worker.TaskAttemptContext;
    +
    +import java.io.IOException;
    +
    +/**
    + * This is a physical executor to store a row immediately
    + */
    +public class InsertRowExec extends UnaryPhysicalExec {
    --- End diff --
    
    Currently, StoreTableExec cannot handle OLTP-like storages. We should 
modify StoreTableExec::openNewFile for them. The main objective of 
InsertRowExec is to avoid StoreTableExec to be multiple purposed. If we use 
StoreTableExec here, StoreTableExec would be more messy to having more 
exceptional and intuitive conditions in StoreTableExec::openNewFile().


> Implement TablespaceManager to load Tablespaces
> -----------------------------------------------
>
>                 Key: TAJO-1616
>                 URL: https://issues.apache.org/jira/browse/TAJO-1616
>             Project: Tajo
>          Issue Type: Sub-task
>          Components: storage
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>             Fix For: 0.11.0
>
>
> TablespaceManager should load Tablespace according to storage-default.json 
> and storage-site.json.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to