Github user hyunsik commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/601#discussion_r33194715
  
    --- Diff: tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java ---
    @@ -376,7 +375,11 @@ public static int setDateOrder(int dateOrder) {
         // Behavior Control 
---------------------------------------------------------
         $BEHAVIOR_ARITHMETIC_ABORT("tajo.behavior.arithmetic-abort", false),
     
    -    // ResultSet ---------------------------------------------------------
    +    // If True, a partitioned table is overwritten even if a sub query 
leads to no result.
    +    // Otherwise, the table data will be kept if there is no result
    +    
$TABLE_PARTITION_NO_RESULT_OVERWRITE_ENABLED("tajo.partition.overwrite.even-if-no-result",
 false),
    --- End diff --
    
    I have one more suggestion. It would be great if you use PARTITION instead 
of TABLE_PARTITION. It is still clear because we only use the term 'partition' 
to indicate table partition.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to