[
https://issues.apache.org/jira/browse/TAJO-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14614817#comment-14614817
]
ASF GitHub Bot commented on TAJO-1345:
--------------------------------------
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/618#issuecomment-118793127
@blrunner, I have some more comments as follows.
* The error message should be improved when the given column is not a
partition key. Here is an example.
```
default> alter table partitioned_nation add partition (n_comment=1,
n_nationkey=2) location
'hdfs://localhost:7020/tajo/warehouse/default/partitioned_nation/col1=test/col2=2';
ERROR: n_comment
```
* I wonder that what will happen when an ```add partition``` statement is
executed with the already existing location as follows.
* The ```add partition``` statement does not create the full path of
partition as follows.
```
default> alter table partitioned_nation add partition (n_regionkey=1,
n_nationkey=2) location
'hdfs://localhost:7020/tajo/warehouse/default/partitioned_nation/col1=test/col2=2';
OK
default> \dfs -ls
hdfs://localhost:7020/tajo/warehouse/default/partitioned_nation/col1=test
default>
```
> Implement logical plan part and DDL executor for alter partition.
> -----------------------------------------------------------------
>
> Key: TAJO-1345
> URL: https://issues.apache.org/jira/browse/TAJO-1345
> Project: Tajo
> Issue Type: Sub-task
> Components: planner/optimizer
> Reporter: Jaehwa Jung
> Assignee: Jaehwa Jung
> Fix For: 0.11.0
>
> Attachments: TAJO-1345.patch
>
>
> See the title. The main objective of this issue is to implement the logical
> planning part and the DDL executor part for alter table partition support.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)