Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/593#issuecomment-120859618
Not all changes are shown in the diff in github due to lots of changes. So,
I leave some comments here.
* ```cachekey``` in ```JoinGraphContext``` should be changed to a local
member variable. Its cache effect is trivial because the object lifecycle is
very short.
* the member variable LOG in GreedyHeuristicJoinOrderAlgorithm is added
but is not used.
* PlannerUtil::isSymmetricJoin includes the comment about commutative.
But, the method name has been changed from isCommutativeJoin to
isSymmetricJoin. As far as I know, commutative join is used in common for the
exact meaning we know. But, symmetric join is not usual. Please see two links:
symmetric join (https://goo.gl/d4uOO3) vs. commutative join
(https://goo.gl/oFCgtM).
I'm still reviewing the patch. I'll give more comments soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
