[
https://issues.apache.org/jira/browse/TAJO-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14625658#comment-14625658
]
ASF GitHub Bot commented on TAJO-1352:
--------------------------------------
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/593#issuecomment-121105876
Additional comments:
* The javadoc in JoinOrderAlgorithm::FoundJoinOrder includes wrong
parameter name. That is, joinGraph should be joinGraphContext.
* Methods (especially public methods) in JoinOrderingUtil seem to need
Javadoc because it may be hard to guess their exact purpose from their
signature.
> Improve the join order algorithm to consider missed cases of associative join
> operators
> ---------------------------------------------------------------------------------------
>
> Key: TAJO-1352
> URL: https://issues.apache.org/jira/browse/TAJO-1352
> Project: Tajo
> Issue Type: Improvement
> Components: planner/optimizer
> Reporter: Jihoon Son
> Assignee: Jihoon Son
> Attachments: JoinGraph.png
>
>
> TAJO-1277 fixes a bug related to the associativity of join operators, but
> there are still some missed cases that join operators are associative. This
> work should include the cases described in the following links:
> * http://stackoverflow.com/questions/20022196/are-left-outer-joins-associative
> * https://cwiki.apache.org/confluence/display/Hive/LanguageManual+Joins
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
