Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/608#issuecomment-121633024
@jinossy, really nice work!
I'm still reviewing and not finished yet. Here, I left some comments first,
and will finish soon.
* StringUtils.java
* The comment of isPureAscii() is incomplete.
* QueryCoordinatorProtocol.proto
* As you know, @hyunsik is working on refactoring our error propagation
system. According to the guide at
https://cwiki.apache.org/confluence/display/TAJO/RPC+Protocol+Design+Guide,
please separate QueryCoordinatorProtocolService from this file.
* Also, please add some comments for the methods of
QueryCoordinatorProtocolService.
* QueryInProgress.java
* Please change the comments of allocateToQueryMaster() into the formal
java doc format.
* Please add some comments for submitToQueryMaster().
* QueryManager.java
* The name of startQueryJob() looks not intuitive. How about
isQueryExecutable()?
* TajoResourceManager.java
* Please remove the unused parameter, ```systemConf```, from the
constructor.
* QuerySchedulingInfo.java
* Please add some comments for the class and its variables.
* SimpleScheduler.java
* Please add some comments for the class.
* Would you please explain what PARALLEL_QUERY_LIMIT means?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
