Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/621#discussion_r34963650
--- Diff:
tajo-catalog/tajo-catalog-client/src/main/proto/CatalogProtocol.proto ---
@@ -24,53 +24,128 @@ option java_generate_equals_and_hash = true;
import "CatalogProtos.proto";
import "PrimitiveProtos.proto";
+message GetTablespacesResponse {
+ required ReturnState state = 1;
+ repeated TablespaceProto tablespace = 2;
+}
+
+message GetTablespaceResponse {
+ required ReturnState state = 1;
+ optional TablespaceProto tablespace = 2;
+}
+
+message GetDatabasesResponse {
+ required ReturnState state = 1;
+ repeated DatabaseProto database = 2;
+}
+
+message TableDescResponse {
+ required ReturnState state = 1;
+ optional TableDescProto table = 2;
+}
+
+message GetTablesResponse {
+ required ReturnState state = 1;
+ repeated TableDescriptorProto table = 2;
+}
+
+message FunctionDescResponse {
--- End diff --
My intension was to merge it into FunctionResponse in ClientProtos.proto
because duplicate proto type is used in multiple places. But, I finished the
merge yet. I'll merge them in this patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
