Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/635#discussion_r34965599
--- Diff:
tajo-catalog/tajo-catalog-drivers/tajo-hive/src/test/java/org/apache/tajo/catalog/store/TestHiveCatalogStore.java
---
@@ -85,34 +86,36 @@ public static void tearDown() throws IOException {
@Test
public void testTableUsingTextFile() throws Exception {
- TableMeta meta = new TableMeta("CSV", new KeyValueSet());
-
- org.apache.tajo.catalog.Schema schema = new
org.apache.tajo.catalog.Schema();
- schema.addColumn("c_custkey", TajoDataTypes.Type.INT4);
- schema.addColumn("c_name", TajoDataTypes.Type.TEXT);
- schema.addColumn("c_address", TajoDataTypes.Type.TEXT);
- schema.addColumn("c_nationkey", TajoDataTypes.Type.INT4);
- schema.addColumn("c_phone", TajoDataTypes.Type.TEXT);
- schema.addColumn("c_acctbal", TajoDataTypes.Type.FLOAT8);
- schema.addColumn("c_mktsegment", TajoDataTypes.Type.TEXT);
- schema.addColumn("c_comment", TajoDataTypes.Type.TEXT);
-
- TableDesc table = new TableDesc(CatalogUtil.buildFQName(DB_NAME,
CUSTOMER), schema, meta,
+ for (String storage: storages) {
--- End diff --
I don't think that we need all unit tests for each storage type. You just
add OR condition for TEXT and CSV and all other codes are the same. You need to
add an unit test about your change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
