[
https://issues.apache.org/jira/browse/TAJO-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14633023#comment-14633023
]
ASF GitHub Bot commented on TAJO-1690:
--------------------------------------
Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/635#discussion_r34965599
--- Diff:
tajo-catalog/tajo-catalog-drivers/tajo-hive/src/test/java/org/apache/tajo/catalog/store/TestHiveCatalogStore.java
---
@@ -85,34 +86,36 @@ public static void tearDown() throws IOException {
@Test
public void testTableUsingTextFile() throws Exception {
- TableMeta meta = new TableMeta("CSV", new KeyValueSet());
-
- org.apache.tajo.catalog.Schema schema = new
org.apache.tajo.catalog.Schema();
- schema.addColumn("c_custkey", TajoDataTypes.Type.INT4);
- schema.addColumn("c_name", TajoDataTypes.Type.TEXT);
- schema.addColumn("c_address", TajoDataTypes.Type.TEXT);
- schema.addColumn("c_nationkey", TajoDataTypes.Type.INT4);
- schema.addColumn("c_phone", TajoDataTypes.Type.TEXT);
- schema.addColumn("c_acctbal", TajoDataTypes.Type.FLOAT8);
- schema.addColumn("c_mktsegment", TajoDataTypes.Type.TEXT);
- schema.addColumn("c_comment", TajoDataTypes.Type.TEXT);
-
- TableDesc table = new TableDesc(CatalogUtil.buildFQName(DB_NAME,
CUSTOMER), schema, meta,
+ for (String storage: storages) {
--- End diff --
I don't think that we need all unit tests for each storage type. You just
add OR condition for TEXT and CSV and all other codes are the same. You need to
add an unit test about your change.
> Create table using text file fails in HiveCatalogStore.
> -------------------------------------------------------
>
> Key: TAJO-1690
> URL: https://issues.apache.org/jira/browse/TAJO-1690
> Project: Tajo
> Issue Type: Bug
> Components: Catalog
> Reporter: Jaehwa Jung
> Assignee: Jaehwa Jung
>
> Create table using text file fails in HiveCatalogStore as follows.
> * TSQL
> {code:xml}
> default> create external table supplier (S_SUPPKEY bigint, S_NAME text,
> S_ADDRESS text, S_NATIONKEY bigint, S_PHONE text, S_ACCTBAL double, S_COMMENT
> text) using text with ('textfile.delimiter'='|') location
> 'hdfs://localhost:9010/tpch/supplier';
> ERROR: Cannot create table "default.supplier".
> {code}
> * TajoMaster log
> {code:xml}
> 2015-07-18 01:40:12,055 ERROR org.apache.tajo.catalog.CatalogServer:
> org.apache.tajo.common.exception.NotImplementedException: text
> org.apache.tajo.catalog.exception.CatalogException:
> org.apache.tajo.common.exception.NotImplementedException: text
> at
> org.apache.tajo.catalog.store.HiveCatalogStore.createTable(HiveCatalogStore.java:553)
> at
> org.apache.tajo.catalog.CatalogServer$CatalogProtocolHandler.createTable(CatalogServer.java:602)
> at
> org.apache.tajo.catalog.AbstractCatalogClient.createTable(AbstractCatalogClient.java:406)
> at
> org.apache.tajo.master.exec.DDLExecutor.createTable(DDLExecutor.java:275)
> at
> org.apache.tajo.master.exec.DDLExecutor.createTable(DDLExecutor.java:211)
> at org.apache.tajo.master.exec.DDLExecutor.execute(DDLExecutor.java:91)
> at
> org.apache.tajo.master.exec.QueryExecutor.execute(QueryExecutor.java:107)
> {code}
> It seems that HiveCatalogStore just support csv file format. We need to
> support text file format in HiveCatalogStore.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
