[
https://issues.apache.org/jira/browse/TAJO-1343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636225#comment-14636225
]
ASF GitHub Bot commented on TAJO-1343:
--------------------------------------
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/634#issuecomment-123562379
+1
The patch looks good to me. I leaved one trivial issue. It's up to you.
In addition, you added the removal code in QueryContext.
https://github.com/apache/tajo/pull/634/files#diff-e0e47538675376e2e0b96ce307a9676bR49
I think that it would be handled in other places. But, the current
workaround looks good to me. I'll solve it in another jira.
Thanks!
> Improve the memory usage of physical executors
> ----------------------------------------------
>
> Key: TAJO-1343
> URL: https://issues.apache.org/jira/browse/TAJO-1343
> Project: Tajo
> Issue Type: Improvement
> Components: Physical Operator
> Reporter: Jihoon Son
> Assignee: Jihoon Son
> Priority: Critical
> Fix For: 0.11.0
>
> Attachments: 1343-memory.png, master-memory.png
>
>
> *Introduction*
> Basically, the tuple instance is maintained as a singleton in physical
> operators. However, there are some memory-based operator types which need to
> keep multiple tuples in the memory. In these operators, multiple instances
> must be created for each tuple.
> *Problem*
> Currently, there are some temporal routines to avoid unexpected problems due
> to the singleton instance of tuple. However, the methodology is inconsistent
> and complex, which causes unexpected bugs.
> *Solution*
> A consistent methodology is needed to handle this problem. Only the operators
> that keep multiple tuples in memory must maintain those tuples with separate
> instances.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
