[ 
https://issues.apache.org/jira/browse/TAJO-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14642639#comment-14642639
 ] 

ASF GitHub Bot commented on TAJO-1465:
--------------------------------------

Github user hyunsik commented on the pull request:

    https://github.com/apache/tajo/pull/652#issuecomment-125183236
  
    The patch looks good to me. I leave one comment about timezone.
    
    Also, this patch borrows a part of orc implementation. So, we need to 
continue upgrading the borrowed orc implementation. Could you add some comments 
to point out borrowed ones or our own implementation?


> Add ORCFileAppender to write into ORCFile table
> -----------------------------------------------
>
>                 Key: TAJO-1465
>                 URL: https://issues.apache.org/jira/browse/TAJO-1465
>             Project: Tajo
>          Issue Type: Sub-task
>          Components: Storage
>    Affects Versions: 0.10.0
>            Reporter: Dongjoon Hyun
>            Assignee: Jongyoung Park
>              Labels: orc
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to