Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/630#discussion_r35871901
--- Diff:
tajo-catalog/tajo-catalog-drivers/tajo-hive/src/main/java/org/apache/tajo/catalog/store/HiveCatalogStore.java
---
@@ -957,6 +1026,54 @@ private boolean existColumn(final String databaseName
,final String tableName ,
}
@Override
+ public void addPartitions(String databaseName, String tableName,
List<CatalogProtos.PartitionDescProto> partitions
+ , boolean ifNotExists) throws CatalogException {
+ HiveCatalogStoreClientPool.HiveCatalogStoreClient client = null;
+ List<Partition> addPartitions = TUtil.newList();
+ CatalogProtos.PartitionDescProto existingPartition = null;
+
+ try {
+ client = clientPool.getClient();
+ for (CatalogProtos.PartitionDescProto partitionDescProto :
partitions) {
+ existingPartition = getPartition(databaseName, tableName,
partitionDescProto.getPartitionName());
+
+ // Unfortunately, hive client add_partitions doesn't run as
expected. The method never read the ifNotExists
+ // parameter. So, if Tajo add existing partition to Hive, it will
threw AlreadyExistsException. To avoid
--- End diff --
s/adds/add/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
