[ 
https://issues.apache.org/jira/browse/TAJO-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14647650#comment-14647650
 ] 

ASF GitHub Bot commented on TAJO-1346:
--------------------------------------

Github user hyunsik commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/630#discussion_r35872100
  
    --- Diff: 
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java
 ---
    @@ -1065,6 +1068,47 @@ public GetTablePartitionsResponse 
getAllPartitions(RpcController controller, Nul
         }
     
         @Override
    +    public ReturnState addPartitions(RpcController controller, 
AddPartitionsProto request)
    +      throws ServiceException {
    +
    +      TableIdentifierProto identifier = request.getTableIdentifier();
    +      String databaseName = identifier.getDatabaseName();
    +      String tableName = identifier.getTableName();
    +
    +
    +      if (metaDictionary.isSystemDatabase(databaseName)) {
    +        throw new ServiceException(databaseName + " is a system database. 
It does not contain any partitioned tables.");
    --- End diff --
    
    Don't throw any exception. You can return proper ReturnState.


> Create dynamic partitions to CatalogStore by running insert query or CTAS 
> query.
> --------------------------------------------------------------------------------
>
>                 Key: TAJO-1346
>                 URL: https://issues.apache.org/jira/browse/TAJO-1346
>             Project: Tajo
>          Issue Type: Sub-task
>          Components: Physical Operator
>            Reporter: Jaehwa Jung
>            Assignee: Jaehwa Jung
>
> Currently, If new partitions are added to HDFS by ColPartitionStoreExec, 
> CatalogStore will not be aware of these partitions. So, Tajo need to load 
> newly added partitions automatically to CatalogStore by running insert query 
> or CTAS query.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to