[ 
https://issues.apache.org/jira/browse/TAJO-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14648559#comment-14648559
 ] 

ASF GitHub Bot commented on TAJO-1725:
--------------------------------------

Github user jinossy commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/667#discussion_r35937479
  
    --- Diff: tajo-core/src/main/java/org/apache/tajo/worker/TaskImpl.java ---
    @@ -400,10 +401,14 @@ public void run() throws Exception {
             }
           }
         } catch (Throwable e) {
    +      // clean up TaskImpl resource
           error = e ;
    -      LOG.error(e.getMessage(), e);
           stopScriptExecutors();
           context.stop();
    +
    +      // rethrow the exception in order to propagate the abnormal status 
to TaskContainer
    +      throw new TajoInternalError(e);
    --- End diff --
    
    If an exception causes in physical operator, it can be sent failure report 
in finally block. But rethrow the exception are sent report twice


> TaskContainer can hang when RuntimeException occurs in TaskImpl.
> ----------------------------------------------------------------
>
>                 Key: TAJO-1725
>                 URL: https://issues.apache.org/jira/browse/TAJO-1725
>             Project: Tajo
>          Issue Type: Bug
>          Components: Worker
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>             Fix For: 0.11.0
>
>
> TaskContainer can hang when RuntimeException occurs in TaskImpl. The reason 
> is as follows:
>  * TaskContainer can be aborted by Exception.
>  * TaskImpl running in TaskContainer does not throw Throwable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to