Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/662#discussion_r35949195
--- Diff:
tajo-client/src/main/java/org/apache/tajo/client/CatalogAdminClient.java ---
@@ -133,9 +135,10 @@ TableDesc createExternalTable(final String tableName,
final Schema schema, final
* @return Table description
* @throws java.sql.SQLException
*/
- TableDesc getTableDesc(final String tableName) throws SQLException;
+ TableDesc getTableDesc(final String tableName) throws
UndefinedTableException;
- List<CatalogProtos.FunctionDescProto> getFunctions(final String
functionName) throws SQLException;
+ List<CatalogProtos.FunctionDescProto> getFunctions(final String
functionName)
+ throws AmbiguousFunctionException, UndefinedFunctionException;
--- End diff --
It would be better if ```getFunctions``` returns an empty list rather than
throwing an ```UndefinedFunctionException``` when there is no function of the
given name.
In addition, this method should return a list of the functions of the given
name. So, ```AmbiguousFunctionException``` is inappropriate.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
