[
https://issues.apache.org/jira/browse/TAJO-1699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14651427#comment-14651427
]
ASF GitHub Bot commented on TAJO-1699:
--------------------------------------
Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/662#discussion_r36056184
--- Diff:
tajo-client/src/main/java/org/apache/tajo/client/CatalogAdminClientImpl.java ---
@@ -200,12 +231,17 @@ public TableDesc getTableDesc(final String tableName)
throws SQLException {
throw new RuntimeException(e);
}
- throwIfError(res.getState());
+ if (isThisError(res.getState(), Errors.ResultCode.UNDEFINED_TABLE)) {
+ throw new UndefinedTableException(res.getState());
+ }
+
+ ensureOk(res.getState());
return CatalogUtil.newTableDesc(res.getTable());
}
@Override
- public List<FunctionDescProto> getFunctions(final String functionName)
throws SQLException {
+ public List<FunctionDescProto> getFunctions(final String functionName)
+ throws AmbiguousFunctionException, UndefinedFunctionException {
--- End diff --
Fixed too.
> Tajo Java Client version 2
> --------------------------
>
> Key: TAJO-1699
> URL: https://issues.apache.org/jira/browse/TAJO-1699
> Project: Tajo
> Issue Type: Improvement
> Components: Java Client
> Reporter: Hyunsik Choi
> Assignee: Hyunsik Choi
> Fix For: 0.11.0
>
>
> I propose Tajo Java Client version 2. Its motivations are as follows:
> * After TAJO-1625, the error propagation has been changed significantly.
> Java Client should make use the new error propagation system. Java Client
> should throw the proper exceptions.
> * Many Java API exposes internal data structure and protocol buffer data
> structure. It requires users to understand its internal behavior and
> architecture. We should hide them from users.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
