[
https://issues.apache.org/jira/browse/TAJO-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14653234#comment-14653234
]
ASF GitHub Bot commented on TAJO-1735:
--------------------------------------
Github user blrunner commented on a diff in the pull request:
https://github.com/apache/tajo/pull/673#discussion_r36165105
--- Diff:
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java
---
@@ -304,9 +295,25 @@ public GetTablespaceListResponse
getAllTablespaces(RpcController controller, Nul
throws ServiceException {
rlock.lock();
try {
+
+ // retrieves tablespaces from catalog store
+ final List<TablespaceProto> tableSpaces =
Lists.newArrayList(store.getTablespaces());
+
+ // retrieves tablespaces from linked meta data
+
tableSpaces.addAll(Collections2.transform(linkedMetadataManager.getTablespaces(),
--- End diff --
Could you explain why you use Collections2?
> Implement MetadataProvider and LinkedMetadataManager
> ----------------------------------------------------
>
> Key: TAJO-1735
> URL: https://issues.apache.org/jira/browse/TAJO-1735
> Project: Tajo
> Issue Type: Sub-task
> Components: Catalog
> Reporter: Hyunsik Choi
> Assignee: Hyunsik Choi
> Fix For: 0.11.0
>
>
> This patch add a MetadataProvider interface and LinkedMetadataManager;
> * MetadataProvider provides a way to access linked meta data store through
> an unified API.
> * LinkedMetadataManager manages all MetadataProvider instances.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
