Github user hyunsik commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/624#discussion_r36580037
  
    --- Diff: 
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java
 ---
    @@ -1195,6 +1249,71 @@ public GetTablePartitionsResponse 
getAllPartitions(RpcController controller, Nul
         }
     
         @Override
    +    public GetTablePartitionsResponse 
getPartitionsByDirectSql(RpcController controller,
    --- End diff --
    
    Catalog API is public APIs. In terms of this point, this API design does 
not make sense due to the following problems:
     * Users should know its schema and underlying persistent storage.
      * So, users should make SQL statements for all persistent storages.
     * This approach is very prone to SQL injection.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to