Github user jihoonson commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/680#discussion_r36610932
  
    --- Diff: 
tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java
 ---
    @@ -805,11 +851,19 @@ public final boolean containFunction(final String 
signature, FunctionType funcTy
       }
     
       @Override
    -  public final boolean alterTable(final AlterTableDesc desc) {
    +  public final void alterTable(final AlterTableDesc desc) throws 
UndefinedTableException, DuplicateColumnException,
    +      InsufficientPrivilegeException, DuplicateTableException {
     
         try {
           final BlockingInterface stub = getStub();
    -      return isSuccess(stub.alterTable(null, desc.getProto()));
    +      final ReturnState state = stub.alterTable(null, desc.getProto());
    --- End diff --
    
    CatalogServer.alterTable() throws only ```UndefinedTableException```. Did 
you add handling other exceptions for future work? Even though you did, I think 
that ```DuplicateTableException``` does not occur.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to