[
https://issues.apache.org/jira/browse/TAJO-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695263#comment-14695263
]
Hudson commented on TAJO-1748:
------------------------------
FAILURE: Integrated in Tajo-master-CODEGEN-build #436 (See
[https://builds.apache.org/job/Tajo-master-CODEGEN-build/436/])
TAJO-1748: Refine client APIs to throw specific exceptions. (hyunsik: rev
903151eadc457ed7f29e96ca3acf46e73324d844)
*
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/UndefinedTablespaceException.java
* tajo-core/src/test/java/org/apache/tajo/engine/eval/TestEvalTreeUtil.java
* tajo-plan/src/main/java/org/apache/tajo/plan/LogicalPlanner.java
* tajo-client/src/main/java/org/apache/tajo/client/CatalogAdminClient.java
*
tajo-common/src/main/java/org/apache/tajo/exception/UnknownDataFormatException.java
*
tajo-plan/src/main/java/org/apache/tajo/plan/serder/LogicalNodeDeserializer.java
*
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/UndefinedColumnException.java
* tajo-common/src/main/java/org/apache/tajo/exception/DefaultTajoException.java
*
tajo-common/src/main/java/org/apache/tajo/exception/UndefinedIndexException.java
* tajo-common/src/main/java/org/apache/tajo/exception/InvalidNameException.java
* tajo-plan/src/main/java/org/apache/tajo/plan/LogicalPlanPreprocessor.java
*
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/MetadataProvider.java
* tajo-common/src/main/java/org/apache/tajo/exception/SQLExceptionUtil.java
* tajo-plan/src/main/java/org/apache/tajo/plan/function/FunctionInvoke.java
*
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/dictionary/InfoSchemaMetadataDictionary.java
*
tajo-common/src/main/java/org/apache/tajo/exception/UndefinedFunctionException.java
*
tajo-plan/src/main/java/org/apache/tajo/plan/function/ClassBasedAggFunctionInvoke.java
*
tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestCatalog.java
*
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/CatalogStore.java
*
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/UndefinedFunctionException.java
*
tajo-plan/src/main/java/org/apache/tajo/plan/nameresolver/ResolverByLegacy.java
* tajo-core/src/main/java/org/apache/tajo/querymaster/Stage.java
*
tajo-core/src/test/resources/results/TestTajoCliNegatives/testQueryFailure.result
*
tajo-common/src/main/java/org/apache/tajo/exception/InvalidDataTypeException.java
*
tajo-common/src/main/java/org/apache/tajo/exception/DuplicateTableException.java
*
tajo-plan/src/main/java/org/apache/tajo/plan/nameresolver/ResolverByRelsAndSubExprs.java
* tajo-core/src/test/java/org/apache/tajo/client/TestQueryClientExceptions.java
*
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/InsufficientPrivilegeException.java
*
tajo-common/src/main/java/org/apache/tajo/exception/InvalidTablePropertyException.java
*
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/AmbiguousTableException.java
*
tajo-common/src/main/java/org/apache/tajo/exception/UndefinedPartitionKeyException.java
*
tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/RowStoreUtil.java
*
tajo-common/src/main/java/org/apache/tajo/exception/DuplicateFunctionException.java
* tajo-core/src/test/java/org/apache/tajo/engine/eval/TestSQLExpression.java
*
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/UndefinedPartitionException.java
*
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/DuplicateFunctionException.java
*
tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/json/JsonLineSerializer.java
* tajo-core/src/test/resources/queries/TestTruncateTable/table1_ddl.sql
*
tajo-common/src/main/java/org/apache/tajo/exception/DuplicateIndexException.java
*
tajo-common/src/main/java/org/apache/tajo/exception/InvalidOperationException.java
* tajo-core/src/test/java/org/apache/tajo/engine/query/TestAlterTablespace.java
*
tajo-common/src/main/java/org/apache/tajo/exception/DuplicateDatabaseException.java
* tajo-core/src/main/java/org/apache/tajo/querymaster/QueryMasterTask.java
*
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MemStore.java
*
tajo-core/src/test/java/org/apache/tajo/engine/planner/physical/TestPhysicalPlanner.java
* tajo-common/src/main/java/org/apache/tajo/exception/InternalException.java
* tajo-plan/src/main/java/org/apache/tajo/plan/function/AggFunctionInvoke.java
*
tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/AbstractScanner.java
* tajo-core/src/test/java/org/apache/tajo/QueryTestCaseBase.java
*
tajo-common/src/main/java/org/apache/tajo/exception/CatalogUpgradeRequiredException.java
*
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/UndefinedIndexException.java
*
tajo-common/src/main/java/org/apache/tajo/exception/QueryNotFoundException.java
*
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/AmbiguousFunctionException.java
*
tajo-catalog/tajo-catalog-drivers/tajo-hive/src/main/java/org/apache/tajo/catalog/store/HiveCatalogStore.java
* tajo-client/src/main/java/org/apache/tajo/client/v2/ClientDelegate.java
*
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/UndefinedDatabaseException.java
* tajo-core/src/main/java/org/apache/tajo/engine/planner/PhysicalPlanner.java
*
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/FunctionDesc.java
*
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java
*
tajo-common/src/main/java/org/apache/tajo/exception/UndefinedTableException.java
* tajo-core/src/main/java/org/apache/tajo/ws/rs/resources/DatabasesResource.java
* tajo-plan/src/main/java/org/apache/tajo/plan/serder/EvalNodeDeserializer.java
* tajo-common/src/main/java/org/apache/tajo/exception/TajoException.java
* tajo-core/src/main/java/org/apache/tajo/ws/rs/resources/TablesResource.java
*
tajo-core/src/test/java/org/apache/tajo/engine/function/TestConditionalExpressions.java
* tajo-core/src/main/java/org/apache/tajo/webapp/QueryExecutorServlet.java
*
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/UndefinedPartitionKeyException.java
* tajo-plan/src/main/java/org/apache/tajo/plan/TypeDeterminant.java
* tajo-common/src/main/java/org/apache/tajo/exception/SQLSyntaxError.java
*
tajo-core/src/main/java/org/apache/tajo/engine/planner/global/GlobalPlanner.java
* tajo-plan/src/main/java/org/apache/tajo/plan/nameresolver/NameResolver.java
*
tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/AbstractHBaseAppender.java
*
tajo-catalog/tajo-catalog-drivers/tajo-hive/src/main/java/org/apache/tajo/catalog/store/HiveCatalogUtil.java
* tajo-common/src/main/java/org/apache/tajo/exception/ReturnStateUtil.java
*
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java
*
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MariaDBStore.java
*
tajo-common/src/main/java/org/apache/tajo/exception/UndefinedDatabaseException.java
*
tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/json/JsonLineDeserializer.java
* tajo-common/src/main/java/org/apache/tajo/exception/QueryKilledException.java
* tajo-catalog/tajo-catalog-common/src/main/proto/CatalogProtos.proto
*
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java
*
tajo-common/src/main/java/org/apache/tajo/exception/AmbiguousFunctionException.java
* tajo-client/src/main/java/org/apache/tajo/storage/RowStoreUtil.java
*
tajo-core/src/main/java/org/apache/tajo/engine/planner/PhysicalPlannerImpl.java
* tajo-common/src/main/java/org/apache/tajo/exception/ExceptionUtil.java
* tajo-plan/src/main/java/org/apache/tajo/plan/util/PlannerUtil.java
*
tajo-plan/src/main/java/org/apache/tajo/plan/rewrite/rules/ProjectionPushDownRule.java
* tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/DescTableCommand.java
*
tajo-core/src/test/resources/results/TestTajoCli/testAlterTableAddDropPartition.result
* tajo-core/src/main/java/org/apache/tajo/engine/parser/SQLAnalyzer.java
*
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/DuplicateTableException.java
*
tajo-common/src/main/java/org/apache/tajo/exception/DuplicateColumnException.java
* tajo-client/src/main/java/org/apache/tajo/client/v2/TajoClient.java
* tajo-client/src/main/java/org/apache/tajo/client/QueryClientImpl.java
* tajo-core/src/main/java/org/apache/tajo/worker/TajoQueryEngine.java
*
tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/HBaseScanner.java
*
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Schema.java
* tajo-core/src/main/java/org/apache/tajo/engine/parser/SQLSyntaxError.java
* tajo-plan/src/main/java/org/apache/tajo/plan/verifier/VerificationState.java
* tajo-core/src/test/java/org/apache/tajo/engine/query/TestTruncateTable.java
* tajo-client/src/main/java/org/apache/tajo/client/CatalogAdminClientImpl.java
*
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/DuplicateDatabaseException.java
*
tajo-common/src/main/java/org/apache/tajo/exception/UndefinedTablespaceException.java
* tajo-catalog/tajo-catalog-client/src/main/proto/CatalogProtocol.proto
*
tajo-common/src/main/java/org/apache/tajo/exception/DuplicateTablespaceException.java
* tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java
*
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/PostgreSQLStore.java
*
tajo-common/src/main/java/org/apache/tajo/exception/NotImplementedException.java
* tajo-core/src/main/java/org/apache/tajo/querymaster/Repartitioner.java
* tajo-common/src/main/java/org/apache/tajo/exception/TajoInternalError.java
*
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/DuplicateIndexException.java
*
tajo-common/src/main/java/org/apache/tajo/exception/UndefinedPartitionException.java
* tajo-client/src/main/java/org/apache/tajo/client/TajoClientUtil.java
*
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/LinkedMetadataManager.java
*
tajo-plan/src/main/java/org/apache/tajo/plan/nameresolver/ResolverBySubExprsAndRels.java
* tajo-core/src/main/java/org/apache/tajo/engine/function/FailFunction.java
*
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/AmbiguousPartitionDirectoryExistException.java
* tajo-core/src/test/java/org/apache/tajo/client/TestTajoClient.java
*
tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/SortedInsertRewriter.java
* tajo-plan/src/main/java/org/apache/tajo/plan/serder/LogicalNodeSerializer.java
* tajo-core/src/main/java/org/apache/tajo/master/exec/QueryExecutor.java
*
tajo-common/src/main/java/org/apache/tajo/exception/MetadataConnectionException.java
*
tajo-plan/src/main/java/org/apache/tajo/plan/expr/AggregationFunctionCallEval.java
*
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogService.java
* tajo-core/src/test/java/org/apache/tajo/client/v2/TestTajoClientV2.java
*
tajo-plan/src/main/java/org/apache/tajo/plan/verifier/PreLogicalPlanVerifier.java
* tajo-plan/src/main/java/org/apache/tajo/plan/ExprNormalizer.java
*
tajo-catalog/tajo-catalog-common/src/test/java/org/apache/tajo/catalog/TestFunctionDesc.java
*
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/CatalogExceptionUtil.java
*
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/DuplicateTablespaceException.java
* tajo-core/src/test/java/org/apache/tajo/client/TestTajoClientFailures.java
*
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/UndefinedTableException.java
*
tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/Tablespace.java
*
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/DuplicateColumnException.java
*
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/MetadataConnectionException.java
*
tajo-common/src/main/java/org/apache/tajo/exception/UnknownDataTypeException.java
* tajo-cli/src/main/java/org/apache/tajo/cli/tsql/TajoCli.java
*
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/XMLCatalogSchemaManager.java
* CHANGES
*
tajo-plan/src/main/java/org/apache/tajo/plan/function/ClassBasedScalarFunctionInvoke.java
*
tajo-catalog/tajo-catalog-common/src/test/java/org/apache/tajo/catalog/TestSchema.java
* tajo-client/src/main/java/org/apache/tajo/client/v2/LegacyClientDelegate.java
*
tajo-common/src/main/java/org/apache/tajo/exception/TajoExceptionInterface.java
* tajo-core/src/main/java/org/apache/tajo/master/exec/CreateTableExecutor.java
*
tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/HBaseTablespace.java
*
tajo-common/src/main/java/org/apache/tajo/exception/DataTypeMismatchException.java
*
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/InvalidNameException.java
*
tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java
* tajo-core/src/test/java/org/apache/tajo/engine/query/TestJoinQuery.java
*
tajo-common/src/main/java/org/apache/tajo/exception/AmbiguousPartitionDirectoryExistException.java
*
tajo-common/src/main/java/org/apache/tajo/exception/LMDNoMatchedDatatypeException.java
*
tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestLinkedMetadataManager.java
* tajo-plan/src/main/java/org/apache/tajo/plan/ExprAnnotator.java
*
tajo-common/src/main/java/org/apache/tajo/exception/InsufficientPrivilegeException.java
* tajo-common/src/main/java/org/apache/tajo/exception/TajoError.java
* tajo-core/src/main/java/org/apache/tajo/master/TajoMasterClientService.java
* tajo-core/src/test/java/org/apache/tajo/engine/query/TestHBaseTable.java
* tajo-client/src/main/java/org/apache/tajo/client/TajoClientImpl.java
*
tajo-common/src/main/java/org/apache/tajo/exception/UnimplementedException.java
* tajo-client/src/main/java/org/apache/tajo/client/QueryClient.java
* tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java
*
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/OracleStore.java
*
tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/ConnectDatabaseCommand.java
* tajo-common/src/main/java/org/apache/tajo/exception/QueryFailedException.java
*
tajo-common/src/main/java/org/apache/tajo/exception/MissingTablePropertyException.java
* tajo-common/src/main/java/org/apache/tajo/exception/ErrorMessages.java
*
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/CatalogException.java
*
tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/HBaseTextSerializerDeserializer.java
*
tajo-common/src/main/java/org/apache/tajo/exception/UndefinedPartitionMethodException.java
* tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/TajoShellCommand.java
* tajo-plan/src/main/java/org/apache/tajo/plan/nameresolver/ResolverByRels.java
*
tajo-common/src/main/java/org/apache/tajo/exception/DuplicatePartitionException.java
*
tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/FileTablespace.java
* tajo-common/src/main/java/org/apache/tajo/exception/TajoRuntimeException.java
* tajo-core/src/test/java/org/apache/tajo/cli/tsql/TestTajoCliNegatives.java
*
tajo-core/src/test/java/org/apache/tajo/client/TestCatalogAdminClientExceptions.java
* tajo-core/src/main/java/org/apache/tajo/master/exec/DDLExecutor.java
*
tajo-common/src/main/java/org/apache/tajo/exception/UnavailableTableLocationException.java
*
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MySQLStore.java
* tajo-common/src/main/java/org/apache/tajo/storage/VTuple.java
* tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java
* tajo-client/src/main/java/org/apache/tajo/client/ClientExceptionUtil.java
*
tajo-common/src/main/java/org/apache/tajo/exception/UnsupportedDataTypeException.java
*
tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/orc/ORCScanner.java
* tajo-client/src/main/java/org/apache/tajo/jdbc/WaitingResultSet.java
*
tajo-common/src/main/java/org/apache/tajo/exception/AmbiguousTableException.java
* tajo-common/src/main/proto/errors.proto
*
tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/ColumnMapping.java
*
tajo-client/src/main/java/org/apache/tajo/client/v2/exception/ClientUnableToConnectException.java
*
tajo-common/src/main/java/org/apache/tajo/exception/UndefinedColumnException.java
*
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java
*
tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/text/DelimitedLineReader.java
*
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/DuplicatePartitionException.java
* tajo-plan/src/main/java/org/apache/tajo/plan/expr/EvalTreeUtil.java
*
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/UndefinedPartitionMethodException.java
* tajo-core/src/main/java/org/apache/tajo/querymaster/Query.java
*
tajo-core/src/test/resources/results/TestTajoCliNegatives/testQuerySyntax.result
*
tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/HBaseBinarySerializerDeserializer.java
> Refine client APIs to throw specific exceptions
> -----------------------------------------------
>
> Key: TAJO-1748
> URL: https://issues.apache.org/jira/browse/TAJO-1748
> Project: Tajo
> Issue Type: Sub-task
> Components: Catalog, Java Client
> Reporter: Hyunsik Choi
> Assignee: Hyunsik Choi
> Fix For: 0.11.0
>
>
> This patch includes lots of API changes in terms of only exceptions. In
> overall, this patch changes throwable exceptions for APIs and unit tests to
> ensure that the APIs throws exact exceptions.
> In sum, this patch includes the following changes:
> * Rename TajoExceptionInterface to DefaultTajoException.
> * Rename UnImplementedException to NotImplementedException.
> * Replace CatalogException by TajoException
> * Move almost TajoException/TajoRunException in tajo-core into tajo-common
> * Remove CatalogException and CatalogExceptionUtil
> * Add throwable exception to all APIs in TajoClient, QueryClient,
> CatalogService, and CatalogAdminClient.
> * Refine all client implementations to throw received exception exactly.
> * Add negative unit tests for all APIs of them
> * Refine Client API v2 to handle exceptional cases like query failed, and
> killed.
> * Add query fail and kill tests for Client v2
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)