[
https://issues.apache.org/jira/browse/TAJO-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14703170#comment-14703170
]
ASF GitHub Bot commented on TAJO-1675:
--------------------------------------
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/653#discussion_r37427089
--- Diff:
tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestAlterTable.java
---
@@ -103,10 +107,33 @@ public final void testAlterTableAddPartition() throws
Exception {
assertTrue(fs.exists(partitionPath));
assertTrue(partitionPath.toString().indexOf("col3=1/col4=2") > 0);
+ boolean existPartition = false;
+ List<CatalogProtos.TablePartitionProto> allPartitions =
catalog.getAllPartitions();
--- End diff --
As I said before, this test should be moved to
TestNonForwardQueryResultSystemScanner. (Maybe this class is also renamed, for
example to TestInformationSchema). Here are some reasons.
First, this class is for testing alter table operation rather than
functionality of information schema. Second, in this implementation, several
tests are mixed together, so it is difficult to figure out which lines test
which functionality. Unit testing is to test the functionality of individual
modules.
> NPE when selecting data from information_schema.partition_keys
> --------------------------------------------------------------
>
> Key: TAJO-1675
> URL: https://issues.apache.org/jira/browse/TAJO-1675
> Project: Tajo
> Issue Type: Bug
> Components: Catalog
> Reporter: Jihoon Son
> Assignee: Jaehwa Jung
> Fix For: 0.11.0
>
>
> See the title.
> You can reproduce as follows.
> {noformat}
> default> create table partitioned_nation (n_name text, n_comment text)
> partition by column (n_nationkey int8, n_regionkey int8) ;
> OK
> default> insert into partitioned_nation select * from nation;
> default> \d partitioned_nation
> table name: default.partitioned_nation
> table uri: hdfs://localhost:7020/tajo/warehouse/default/partitioned_nation
> store type: CSV
> number of rows: 0
> volume: 0 B
> Options:
> 'text.delimiter'='|'
> schema:
> n_name TEXT
> n_comment TEXT
> Partitions:
> type:COLUMN
> columns::n_nationkey (INT8), n_regionkey (INT8)
> default> \c information_schema
> You are now connected to database "information_schema" as user "jihoonson".
> information_schema> select * from partition_keys;
> partition_id, column_name, partition_value
> -------------------------------
> ERROR: java.lang.NullPointerException
> java.sql.SQLException: java.lang.NullPointerException
> at
> org.apache.tajo.jdbc.TajoResultSetBase.next(TajoResultSetBase.java:717)
> at
> org.apache.tajo.cli.tsql.DefaultTajoCliOutputFormatter.printResult(DefaultTajoCliOutputFormatter.java:105)
> at
> org.apache.tajo.cli.tsql.TajoCli.localQueryCompleted(TajoCli.java:558)
> at org.apache.tajo.cli.tsql.TajoCli.executeQuery(TajoCli.java:532)
> at
> org.apache.tajo.cli.tsql.TajoCli.executeParsedResults(TajoCli.java:447)
> at org.apache.tajo.cli.tsql.TajoCli.runShell(TajoCli.java:419)
> at org.apache.tajo.cli.tsql.TajoCli.main(TajoCli.java:692)
> Caused by: java.io.IOException: java.lang.NullPointerException
> at org.apache.tajo.jdbc.FetchResultSet.nextTuple(FetchResultSet.java:80)
> at
> org.apache.tajo.jdbc.TajoResultSetBase.next(TajoResultSetBase.java:711)
> ... 6 more
> Caused by: com.google.protobuf.ServiceException:
> java.lang.NullPointerException
> at
> org.apache.tajo.client.QueryClientImpl.fetchNextQueryResult(QueryClientImpl.java:360)
> at
> org.apache.tajo.client.TajoClientImpl.fetchNextQueryResult(TajoClientImpl.java:134)
> at org.apache.tajo.jdbc.FetchResultSet.nextTuple(FetchResultSet.java:62)
> ... 7 more
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
