Github user jihoonson commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/719#discussion_r38729200
  
    --- Diff: 
tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/HBaseTablespace.java
 ---
    @@ -93,21 +94,13 @@ public void storageInit() throws IOException {
         hbaseConf.set(HConstants.ZOOKEEPER_CLIENT_PORT, splits[1]);
       }
     
    -  @Override
    -  public void setConfig(String name, String value) {
    -  }
    -
    -  @Override
    -  public void setConfigs(Map<String, String> configs) {
    -  }
    -
       public Configuration getHbaseConf() {
         return hbaseConf;
       }
     
       @Override
    -  public long getTableVolume(URI uri) throws IOException {
    -    return 0;
    +  public long getTableVolume(URI uri) throws UnsupportedException {
    +    throw new UnsupportedException();
    --- End diff --
    
    Yes, you are right. NotImplementedException should be thrown when we will 
implement later. 
    I found a workaround to get the total volume of hbase table, that is using 
the HDFS command ```hadoop fs -du```. This will be inefficient, but may be very 
helpful for query planning. So, I think we need to implement this function 
someday. What do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to