[ 
https://issues.apache.org/jira/browse/TAJO-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14734241#comment-14734241
 ] 

ASF GitHub Bot commented on TAJO-1729:
--------------------------------------

GitHub user dkhwangbo opened a pull request:

    https://github.com/apache/tajo/pull/742

    TAJO-1729: No handling of default case in DDLExecutor

    As you can see, there is no handling code of default case in alterTable in 
DDLExecutor.java.
    so add line like execute() in same file.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dkhwangbo/tajo TAJO-1729

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tajo/pull/742.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #742
    
----
commit 96952d52950fde2a6b84661794838d68dab8b792
Author: Dongkyu Hwangbo <[email protected]>
Date:   2015-09-07T07:53:33Z

    reset

commit 04f240b5aa594c35084a081442284da96362005f
Author: Dongkyu Hwangbo <[email protected]>
Date:   2015-09-07T08:00:43Z

    reset

commit 13fbe052d66af951b030188f3602e1bf5cfa7ebb
Author: Dongkyu Hwangbo <[email protected]>
Date:   2015-09-08T00:58:34Z

    Merge remote-tracking branch 'upstream/master'

commit 0b5c1de2fe17af4fb3c8d3e774c20efd74c753f9
Author: Dongkyu Hwangbo <[email protected]>
Date:   2015-09-08T04:48:46Z

    Merge remote-tracking branch 'upstream/master'

commit 8ebc7d7e4af88b0dbd8cf803aeece62419c419f1
Author: Dongkyu Hwangbo <[email protected]>
Date:   2015-09-08T04:52:47Z

    initial commit

----


> No handling of default case in DDLExecutor
> ------------------------------------------
>
>                 Key: TAJO-1729
>                 URL: https://issues.apache.org/jira/browse/TAJO-1729
>             Project: Tajo
>          Issue Type: Improvement
>            Reporter: Hyunsik Choi
>            Assignee: Dongkyu Hwangbo
>            Priority: Trivial
>              Labels: newbie
>
> As you can see, there is no handling code of default case in alterTable in 
> DDLExecutor.java. It potentially may cause a bug because additional cases 
> will be ignored.
> {code:title=alterTable() in DDLExecutor.java}
> break;
>     default:
>       //TODO
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to