Github user hyunsik commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/624#discussion_r39007654
  
    --- Diff: 
tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java
 ---
    @@ -428,15 +429,18 @@ public final PartitionDescProto getPartition(final 
String databaseName, final St
       }
     
       @Override
    -  public final List<PartitionDescProto> getPartitions(final String 
databaseName, final String tableName) {
    +  public final List<PartitionDescProto> getAllPartitions(final String 
databaseName, final String tableName) throws
    +    UndefinedDatabaseException, UndefinedTableException, 
UndefinedPartitionMethodException,
    +    UndefinedPartitionException {
    --- End diff --
    
    It retrieves all partitions. So it may be inproper to throw 
``UndefinedPartitionException``, which should be thrown in the case where there 
is no partition corresponding to a specific partition key.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to