[ 
https://issues.apache.org/jira/browse/TAJO-1739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14736919#comment-14736919
 ] 

ASF GitHub Bot commented on TAJO-1739:
--------------------------------------

Github user jihoonson commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/734#discussion_r39047174
  
    --- Diff: 
tajo-client/src/main/java/org/apache/tajo/client/CatalogAdminClientImpl.java ---
    @@ -241,6 +241,22 @@ public TableDesc getTableDesc(final String tableName) 
throws UndefinedTableExcep
       }
     
       @Override
    +  public List<PartitionDescProto> getAllPartitions(final String tableName) 
{
    +    final BlockingInterface stub = conn.getTMStub();
    +
    +    GetPartitionsResponse response;
    +    try {
    +      response = stub.getPartitionsByTableName(null,
    +        conn.getSessionedString(tableName));
    +    } catch (ServiceException e) {
    +      throw new RuntimeException(e);
    +    }
    +
    +    ensureOk(response.getState());
    --- End diff --
    
    ```UndefinedTableException``` and ```UndefinedDatabaseException``` must be 
handled.


> Add a statement for adding partition to TajoDump
> ------------------------------------------------
>
>                 Key: TAJO-1739
>                 URL: https://issues.apache.org/jira/browse/TAJO-1739
>             Project: Tajo
>          Issue Type: Sub-task
>          Components: SQL Shell
>            Reporter: Jaehwa Jung
>            Assignee: Jaehwa Jung
>             Fix For: 0.11.0, 0.12.0
>
>         Attachments: TAJO-1739.patch, TAJO-1739_2.patch
>
>
> See the title, we need to add a statement for adding partition to TajoDump.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to