[
https://issues.apache.org/jira/browse/TAJO-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14738707#comment-14738707
]
ASF GitHub Bot commented on TAJO-1833:
--------------------------------------
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/752#issuecomment-139227997
+1
The patch looks good to me.
> Refine LogicalPlanPreprocessor to add new rules easily
> ------------------------------------------------------
>
> Key: TAJO-1833
> URL: https://issues.apache.org/jira/browse/TAJO-1833
> Project: Tajo
> Issue Type: Task
> Components: Planner/Optimizer
> Reporter: Jihoon Son
> Assignee: Jihoon Son
>
> LogicalPlanPreprocessor is responsible for building base schema information.
> So far, it has been enough to do this.
> However, to support self-describing data formats well (TAJO-1832), the
> current architecture is difficult to fulfil the requirements.
> To make good use of self-described data format information, schema can be
> guessed at query runtime. I think that this should be done between logical
> plan preprocessing phase and logical planning phase. However, guessing schema
> is also a duty of LogicalPlanPreprocessor, that is building base schema
> information.
> For the sake of generality and extensibility, I think we need to refine
> LogicalPlanPreprocessor to add new rules easily.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
