[ 
https://issues.apache.org/jira/browse/TAJO-1813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14740544#comment-14740544
 ] 

ASF GitHub Bot commented on TAJO-1813:
--------------------------------------

Github user hyunsik commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/749#discussion_r39259558
  
    --- Diff: 
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogService.java
 ---
    @@ -169,7 +169,7 @@ PartitionDescProto getPartition(String databaseName, 
String tableName, String pa
       void addPartitions(String databaseName, String tableName, 
List<PartitionDescProto> partitions
         , boolean ifNotExists) throws UndefinedTableException, 
DuplicatePartitionException, UndefinedPartitionMethodException, 
UndefinedDatabaseException;
     
    -  boolean createIndex(IndexDesc index);
    +  void createIndex(IndexDesc index) throws DuplicateIndexException;
    --- End diff --
    
    If index creation is based on table, it may need 
``Undefined(Table|Database)Exception``.


> Allow external catalog store for unit testing
> ---------------------------------------------
>
>                 Key: TAJO-1813
>                 URL: https://issues.apache.org/jira/browse/TAJO-1813
>             Project: Tajo
>          Issue Type: Task
>          Components: Catalog
>            Reporter: Jihoon Son
>            Assignee: Jihoon Son
>             Fix For: 0.11.0
>
>
> Tajo supports various kinds of database systems for catalog. However, it is 
> very difficult to test every function of catalog with them so far. 
> One easy way for testing is to use unit testing. We can easily test each 
> database system under various circumstances using existing tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to