[
https://issues.apache.org/jira/browse/TAJO-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14740700#comment-14740700
]
ASF GitHub Bot commented on TAJO-1340:
--------------------------------------
Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/671#discussion_r39265815
--- Diff:
tajo-core-tests/src/test/resources/results/TestTajoCli/testHelpSessionVars.result
---
@@ -42,4 +42,5 @@ Available Session Variables:
\set ARITHABORT [true or false] - If true, a running query will be
terminated when an overflow or divide-by-zero occurs.
\set FETCH_ROWNUM [int value] - Sets the number of rows at a time from
Master
\set BLOCK_ON_RESULT [true or false] - Whether to block result set on
query execution
+\set RESULT_COMPRESS [true or false] - Enable resultSet compression
--- End diff --
I have some comments.
* ``RESULT_COMPRESSION`` would be better in terms of naming convention.
* Probably, ``RESULT_COMPRESS`` and its description may seem to enable the
compressed query result.
* Actually, this feature compresses the transfer stream for ResultSet. So,
I'd like to suggest the description as ``Use compression to optimize result
transmission."
* Also, I'd like to suggest this key ``COMPRESSED_RESULT_TRENSFER`` for
session variable. It's clear, but it is somewhat longer than yours. It's up to
you.
Also, I'm going to improve JDBC URL to take defined options instead of
taking directly session variables. For compressed data transfer, I'll add
``?useCompression=true`` like MySQL.
> Change the default output file format.
> --------------------------------------
>
> Key: TAJO-1340
> URL: https://issues.apache.org/jira/browse/TAJO-1340
> Project: Tajo
> Issue Type: Improvement
> Components: Java Client, JDBC Driver, Offheap, Storage
> Reporter: Hyunsik Choi
> Assignee: Jinho Kim
> Fix For: 0.11.0, 0.12.0
>
> Attachments: TAJO-1340.patch, TAJO-1340_2.patch
>
>
> Currently, the default output file is CSV. Due to its nature, CSV has mainly
> three problems:
> * Its line or field delimiter can be duplicated to some character included
> in the result data.
> * Plan text file is likely to be larger than other file formats.
> * Its read and write performance is slow.
> We need to change the default output file format into other file formats. We
> also need to investigate which file format is the best for it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
