Github user eminency commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/652#discussion_r39339177
  
    --- Diff: tajo-common/src/main/java/org/apache/tajo/datum/DatumFactory.java 
---
    @@ -333,7 +330,7 @@ public static DateDatum createDate(Datum datum) {
         case DATE:
           return (DateDatum) datum;
         default:
    -      throw new InvalidCastException(datum.type(), Type.DATE);
    +      throw new TajoRuntimeException(Errors.ResultCode.INVALID_CAST, 
datum.type().toString(), Type.DATE.name());
    --- End diff --
    
    @hyunsik 
    InvalidCastException is not subclass of TajoException, thus it can be used.
    Should it be changed?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to