Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/719#issuecomment-140642251
The latest patch looks good to me! Thank you for quick update.
I have two more comments.
First, as you know, there is a problem of precision of floating numbers. We
can simply ignore this problem until we support decimal or numeric types.
Second, I think that it would be nicer and easier to comprehend the overall
logic related to tablespace if you separate its implementation. More
specifically, in the current implementation, Tablespace is a single class, and
contains information about itself and provides some functionalities to interact
with underlying storage. This makes the implementation quite complicated. So,
how about separating it into Tablespace and TablespaceHandler? I'm just
suggesting you, and you don't have to do it in this ticket even though you
agree. Maybe it causes huge changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
