Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/772#discussion_r39944352
--- Diff:
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/CatalogStore.java
---
@@ -97,13 +97,31 @@ boolean existPartitionMethod(String databaseName,
String tableName) throws Undef
* @return
* @throws TajoException
*/
- List<CatalogProtos.PartitionDescProto> getPartitions(String
databaseName, String tableName) throws
- UndefinedDatabaseException, UndefinedTableException,
UndefinedPartitionMethodException;
+ List<CatalogProtos.PartitionDescProto> getAllPartitions(String
databaseName, String tableName) throws
+ UndefinedDatabaseException, UndefinedTableException,
UndefinedPartitionMethodException,
+ PartitionNotFoundException, UnsupportedException;
CatalogProtos.PartitionDescProto getPartition(String databaseName,
String tableName,
- String partitionName)
- throws UndefinedDatabaseException, UndefinedTableException,
UndefinedPartitionException,
- UndefinedPartitionMethodException;
+ String partitionName)
throws UndefinedDatabaseException,
+ UndefinedTableException, UndefinedPartitionMethodException,
UndefinedPartitionException;
+
+ /**
+ * PartitionedTableRewriter take a look into partition directories for
rewriting filter conditions. But if there
+ * are lots of sub directories on HDFS, such as, more than 10,000
directories,
+ * it might be cause overload to NameNode. Thus, CatalogStore need to
provide partition directories for specified
+ * filter conditions. This scan right partition directories on
CatalogStore with where clause.
+ *
+ * @param request contains database name, table name, algebra
expressions, parameter for executing PrepareStatement
+ * @return list of TablePartitionProto
+ * @throws UndefinedDatabaseException, UndefinedTableException,
UndefinedPartitionMethodException
+ */
+ List<PartitionDescProto> getPartitionsByAlgebra(PartitionsByAlgebraProto
request) throws
+ UndefinedDatabaseException, UndefinedTableException,
UndefinedPartitionMethodException,
+ UndefinedOperatorException, PartitionNotFoundException,
UnsupportedException;
+
+ List<PartitionDescProto> getPartitionsByFilter(PartitionsByFilterProto
request) throws
--- End diff --
You need to add a description for this method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
