Github user blrunner commented on the pull request:

    https://github.com/apache/tajo/pull/772#issuecomment-142674077
  
    I've updated the patch as following:
    
    * **Remove ```CatalogStore::getPartitionsByFilter```**: AbstractDBStore 
doesn't support this method. Also HiveCatalogStore support the method 
restrictedly. You can see the grammar for hive partition api to 
https://github.com/apache/hive/blob/master/metastore/src/java/org/apache/hadoop/hive/metastore/parser/Filter.g.
 But I think that we need the method for user convenience. So I'll implement at 
another jira issue using tajo-sql-parser module and 
```CatalogStore::getPartitionsByAlgebra```.
    
    * **Allow invalid partition directory name**: When adding partition using 
alter statement, users can set partition path freely. But current 
PartitionedTableRewriter just allow well-defined partition directory which 
consists of column name and partition value. So if users use invalid partition 
directory name, they can scan their partitions. To resolve above situation, I 
added list of PartitionDescProto to PartitionedTableScanNode.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to