[ 
https://issues.apache.org/jira/browse/TAJO-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14907468#comment-14907468
 ] 

ASF GitHub Bot commented on TAJO-1887:
--------------------------------------

Github user hyunsik commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/785#discussion_r40396064
  
    --- Diff: 
tajo-plan/src/main/java/org/apache/tajo/plan/verifier/PreLogicalPlanVerifier.java
 ---
    @@ -354,4 +354,14 @@ public Expr visitInsert(Context context, Stack<Expr> 
stack, Insert expr) throws
     
         return expr;
       }
    +
    +  // TODO: This should be removed at TAJO-1891
    +  @Override
    +  public Expr visitAlterTable(Context context, Stack<Expr> stack, 
AlterTable expr) throws TajoException {
    +    if (expr.getAlterTableOpType() == AlterTableOpType.ADD_PARTITION) {
    +      context.state.addVerification(new UnsupportedException("ADD 
PARTITION"));
    --- End diff --
    
    It should be UnimplementedException. UnsupportedException means there is no 
plan to support this feature.


> Disable the alter table add partition statement temporarily.
> ------------------------------------------------------------
>
>                 Key: TAJO-1887
>                 URL: https://issues.apache.org/jira/browse/TAJO-1887
>             Project: Tajo
>          Issue Type: Sub-task
>          Components: Catalog, SQL Parser
>            Reporter: Jaehwa Jung
>            Assignee: Jaehwa Jung
>             Fix For: 0.11.0, 0.12.0
>
>         Attachments: TAJO-1887.patch
>
>
> Currently, users can use arbitrary partition path using alter table 
> statement. But they can't scan their partitions because 
> PartitionedTableRewriter just build tuple from partition path. Fundamentally, 
> we should allow arbitary partition path. But we need to avoid an exception by 
> above situation until tajo allow arbitrary partition path. So it seems that 
> alter table add partition statement is disabled temporarily.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to