[ 
https://issues.apache.org/jira/browse/TAJO-1461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14908645#comment-14908645
 ] 

David Chen commented on TAJO-1461:
----------------------------------

My apologies, I actually have a patch ready for this but got side-tracked by 
other work.

I'll rebase my patch tonight then run it through our internal patch review. I 
should have it posted sometime early next week.

> Follow Protocol Buffer Style Guide
> ----------------------------------
>
>                 Key: TAJO-1461
>                 URL: https://issues.apache.org/jira/browse/TAJO-1461
>             Project: Tajo
>          Issue Type: Improvement
>            Reporter: David Chen
>            Assignee: David Chen
>            Priority: Minor
>
> Similar to HBASE-8915, many of Tajo's Protocol Buffer definitions follow Java 
> conventions (i.e. {{camelCase}} field names) rather than the convention 
> described in the Protocol Buffers Style Guide: 
> https://developers.google.com/protocol-buffers/docs/style
> Since we have been discussing improving portability of Tajo's service 
> interfaces (TAJO-1331, TAJO-1458), it would be good to conform to the 
> Protocol Buffers Style Guide.
> For the most part, this is not a difficult change and for the most part would 
> not result in much change in the generated Java code since the proto compiler 
> will automatically convert {{field_name}} to {{getFieldName}} for the 
> generated Java classes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to