[
https://issues.apache.org/jira/browse/TAJO-1578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14954271#comment-14954271
]
ASF GitHub Bot commented on TAJO-1578:
--------------------------------------
GitHub user dkhwangbo opened a pull request:
https://github.com/apache/tajo/pull/820
TAJO-1578: User configuration for pull server port is ignored.
When TajoPullServerService is initialized, it overwrites user-configured
pull server port with the default value.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dkhwangbo/tajo TAJO-1578
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/820.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #820
----
commit 557441f6ec78078127290885a860d1cd7d1937d4
Author: Dongkyu Hwangbo <[email protected]>
Date: 2015-10-13T02:22:20Z
initial commit
commit 904a83b4399823768fa80e2d495e85dcae7ee4d3
Author: Dongkyu Hwangbo <[email protected]>
Date: 2015-10-13T02:24:41Z
rollback unnecessarily changed
----
> User configuration for pull server port is ignored.
> ---------------------------------------------------
>
> Key: TAJO-1578
> URL: https://issues.apache.org/jira/browse/TAJO-1578
> Project: Tajo
> Issue Type: Bug
> Reporter: Jihoon Son
> Assignee: Dongkyu Hwangbo
> Labels: newbie
>
> See the title.
> When TajoPullServerService is initialized, it overwrites user-configured pull
> server port with the default value as follows.
> {code}
> ...
> @Override
> public void init(Configuration conf) {
> try {
> manageOsCache = conf.getBoolean(SHUFFLE_MANAGE_OS_CACHE,
> DEFAULT_SHUFFLE_MANAGE_OS_CACHE);
> readaheadLength = conf.getInt(SHUFFLE_READAHEAD_BYTES,
> DEFAULT_SHUFFLE_READAHEAD_BYTES);
> int workerNum = conf.getInt("tajo.shuffle.rpc.server.worker-thread-num",
> Runtime.getRuntime().availableProcessors() * 2);
> selector =
> RpcChannelFactory.createServerChannelFactory("TajoPullServerService",
> workerNum)
> .option(ChannelOption.TCP_NODELAY, true)
> .childOption(ChannelOption.ALLOCATOR,
> PooledByteBufAllocator.DEFAULT)
> .childOption(ChannelOption.TCP_NODELAY, true);
> localFS = new LocalFileSystem();
> conf.setInt(TajoConf.ConfVars.PULLSERVER_PORT.varname
> , TajoConf.ConfVars.PULLSERVER_PORT.defaultIntVal);
> super.init(conf);
> LOG.info("Tajo PullServer initialized: readaheadLength=" +
> readaheadLength);
> } catch (Throwable t) {
> LOG.error(t, t);
> }
> }
> ...
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
