Github user jihoonson commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/824#discussion_r41978484
  
    --- Diff: 
tajo-catalog/tajo-catalog-drivers/tajo-hive/src/main/java/org/apache/tajo/catalog/store/HiveCatalogStore.java
 ---
    @@ -1243,7 +1031,7 @@ public void addPartitions(String databaseName, String 
tableName, List<CatalogPro
             // Unfortunately, hive client add_partitions doesn't run as 
expected. The method never read the ifNotExists
             // parameter. So, if Tajo adds existing partition to Hive, it will 
threw AlreadyExistsException. To avoid
             // above error, we need to filter existing partitions before call 
add_partitions.
    -        if (existingPartition == null) {
    +        if (existingPartition != null) {
    --- End diff --
    
    This change is wrong.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to