Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/835#discussion_r42832211
--- Diff:
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java
---
@@ -1134,13 +1068,11 @@ private void setProperties(final int tableId, final
KeyValueSetProto properties)
final String updateSql = "UPDATE " + TB_OPTIONS + " SET VALUE_=? WHERE
TID=? AND KEY_=?";
final String insertSql = "INSERT INTO " + TB_OPTIONS + " (TID, KEY_,
VALUE_) VALUES(?, ?, ?)";
- Connection conn;
PreparedStatement pstmt = null;
Map<String, String> oldProperties = getTableOptions(tableId);
- try {
- conn = getConnection();
+ try (Connection conn = getConnection()) {
--- End diff --
Why do you close the connection here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
