[ 
https://issues.apache.org/jira/browse/TAJO-1922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14985693#comment-14985693
 ] 

ASF GitHub Bot commented on TAJO-1922:
--------------------------------------

Github user hyunsik commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/819#discussion_r43661709
  
    --- Diff: 
tajo-plan/src/main/java/org/apache/tajo/plan/util/PartitionFilterAlgebraVisitor.java
 ---
    @@ -150,8 +151,7 @@ public Expr visitTimestampLiteral(Object ctx, 
Stack<Expr> stack, TimestampLitera
           DateTimeUtil.toUTCTimezone(tm, tz);
     
           sb.append("?").append(" )");
    -      Timestamp timestamp = new 
Timestamp(DateTimeUtil.julianTimeToJavaTime(DateTimeUtil.toJulianTimestamp(tm)));
    -      parameters.add(new Pair(Type.TIMESTAMP, timestamp));
    +      parameters.add(new Pair(Type.TIMESTAMP, new 
TimestampDatum(DateTimeUtil.toJulianTimestamp(tm))));
    --- End diff --
    
    This code seem to change the timestamp to a julian time. Could you check if 
it is valid? We need to make the partitioned table compatible with Apache Hive. 
Hive does not appear to use a julian time.


> Allow date types with IN operator for partition pruning.
> --------------------------------------------------------
>
>                 Key: TAJO-1922
>                 URL: https://issues.apache.org/jira/browse/TAJO-1922
>             Project: Tajo
>          Issue Type: Sub-task
>          Components: Catalog
>    Affects Versions: 0.12.0
>            Reporter: Jaehwa Jung
>            Assignee: Jaehwa Jung
>             Fix For: 0.12.0
>
>
> Currently, Tajo doesn't allow date types with IN operator for partition 
> pruning. If users execute date types with IN operator with partitioned table, 
> users will fail to execute their query as following:
> {code:xml}
> tpch_partition> \d lineitem
> table name: tpch_partition.lineitem
> table uri: hdfs://localhost:9010/tajo/warehouse/tpch_partition/lineitem
> store type: TEXT
> number of rows: 0
> volume: 696.5 MB
> Options: 
>       'transient_lastDdlTime'='1441266430'
>       'text.null'='\\N'
>       'text.delimiter'='|'
> schema: 
> l_orderkey    INT8
> l_partkey     INT8
> l_suppkey     INT8
> l_linenumber  INT8
> l_quantity    FLOAT8
> l_extendedprice       FLOAT8
> l_discount    FLOAT8
> l_tax FLOAT8
> l_returnflag  TEXT
> l_linestatus  TEXT
> l_commitdate  DATE
> l_receiptdate DATE
> l_shipinstruct        TEXT
> l_shipmode    TEXT
> l_comment     TEXT
> Partitions: 
> type:COLUMN
> columns::tpch_partition.lineitem.l_shipdate (DATE)
> tpch_partition> select l_shipdate, count(*) from lineitem where l_shipdate in 
> ( to_date('1992-01-02', 'YYYY-MM-DD') 
> >  ,  to_date('1992-02-24', 'YYYY-MM-DD')) group by l_shipdate;
> ERROR: internal error: Unsupported type: DATE
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to