[
https://issues.apache.org/jira/browse/TAJO-1954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14986458#comment-14986458
]
ASF GitHub Bot commented on TAJO-1954:
--------------------------------------
Github user jinossy commented on a diff in the pull request:
https://github.com/apache/tajo/pull/838#discussion_r43707748
--- Diff:
tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/DistinctGroupbySortAggregationExec.java
---
@@ -172,6 +168,13 @@ public void close() throws IOException {
@Override
public void init() throws IOException {
+ super.init();
+
+ if (aggregateExecs != null) {
--- End diff --
@charsyam
I refer to close() but It seems to the unnecessary checking. Are you
working on this operator ?
> Fix memory leak in physical operator
> ------------------------------------
>
> Key: TAJO-1954
> URL: https://issues.apache.org/jira/browse/TAJO-1954
> Project: Tajo
> Issue Type: Bug
> Components: Physical Operator
> Affects Versions: 0.10.0
> Reporter: Jinho Kim
> Assignee: Jinho Kim
> Fix For: 0.12.0, 0.11.1
>
>
> A physical operator should be closed but some operator does not call to close.
> {noformat}
> it's garbage-collected. See
> http://netty.io/wiki/reference-counted-objects.html for more information.
> Recent access records: 1
> #1:
>
> io.netty.buffer.AdvancedLeakAwareByteBuf.nioBuffer(AdvancedLeakAwareByteBuf.java:673)
> org.apache.tajo.storage.RawFile$RawFileScanner.init(RawFile.java:103)
>
> org.apache.tajo.engine.planner.physical.SeqScanExec.initScanner(SeqScanExec.java:286)
>
> org.apache.tajo.engine.planner.physical.SeqScanExec.init(SeqScanExec.java:191)
>
> org.apache.tajo.engine.planner.physical.UnaryPhysicalExec.init(UnaryPhysicalExec.java:53)
>
> org.apache.tajo.engine.planner.physical.ExternalSortExec.init(ExternalSortExec.java:147)
>
> org.apache.tajo.engine.planner.physical.UnaryPhysicalExec.init(UnaryPhysicalExec.java:53)
>
> org.apache.tajo.engine.planner.physical.ColPartitionStoreExec.init(ColPartitionStoreExec.java:117)
> org.apache.tajo.worker.TaskImpl.run(TaskImpl.java:403)
> org.apache.tajo.worker.TaskContainer.run(TaskContainer.java:65)
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> java.util.concurrent.FutureTask.run(FutureTask.java:266)
>
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> java.lang.Thread.run(Thread.java:745)
> {noformat}
> {noformat}
> 2015-10-27 14:10:05,557 ERROR: io.netty.util.ResourceLeakDetector
> (error(527)) - LEAK: ByteBuf.release() was not called before it's
> garbage-collected. See http://netty.io/wiki/reference-counted-objects.html
> for more information.
> Recent access records: 1
> #1:
>
> io.netty.buffer.AdvancedLeakAwareByteBuf.nioBuffer(AdvancedLeakAwareByteBuf.java:673)
> org.apache.tajo.storage.RawFile$RawFileScanner.init(RawFile.java:103)
>
> org.apache.tajo.engine.planner.physical.SeqScanExec.initScanner(SeqScanExec.java:286)
>
> org.apache.tajo.engine.planner.physical.SeqScanExec.init(SeqScanExec.java:191)
>
> org.apache.tajo.engine.planner.physical.UnaryPhysicalExec.init(UnaryPhysicalExec.java:53)
>
> org.apache.tajo.engine.planner.physical.ExternalSortExec.init(ExternalSortExec.java:147)
>
> org.apache.tajo.engine.planner.physical.UnaryPhysicalExec.init(UnaryPhysicalExec.java:53)
>
> org.apache.tajo.engine.planner.physical.AggregationExec.init(AggregationExec.java:53)
>
> org.apache.tajo.engine.planner.physical.DistinctGroupbySortAggregationExec.<init>(DistinctGroupbySortAggregationExec.java:73)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
