[ 
https://issues.apache.org/jira/browse/TAJO-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14993339#comment-14993339
 ] 

Tajo QA commented on TAJO-1925:
-------------------------------

{color:red}*-1 overall.*{color}  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12770969/TAJO-1925.patch
  against master revision release-0.9.0-rc0-558-g68d2c70.

    {color:green}+1 @author.{color}  The patch does not contain any @author 
tags.

    {color:green}+1 tests included.{color}  The patch appears to include 1 new 
or modified test files.

    {color:green}+1 javac.{color}  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc.{color}  The applied patch does not increase the 
total number of javadoc warnings.

    {color:green}+1 checkstyle.{color}  The patch generated 0 code style errors.

    {color:red}-1 findbugs.{color}  The patch appears to cause Findbugs 
(version 2.0.3) to fail.

    {color:green}+1 release audit.{color}  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 core tests.{color}  The patch failed these unit tests in 
tajo-algebra tajo-catalog/tajo-catalog-drivers/tajo-hive 
tajo-catalog/tajo-catalog-server tajo-common tajo-core tajo-core-tests 
tajo-plan: 
                  org.apache.tajo.ws.rs.resources.TestDatabasesResource
                  org.apache.tajo.master.TestQueryResult
                  org.apache.tajo.ha.TestHAServiceHDFSImpl
                  org.apache.tajo.engine.query.TestCrossJoin
                  org.apache.tajo.engine.query.TestMultipleJoinTypes
                  org.apache.tajo.client.TestCatalogAdminClientExceptions
                  org.apache.tajo.engine.query.TestDropTable
                  org.apache.tajo.engine.function.TestJsonFunctions
                  org.apache.tajo.engine.query.TestCommonConditionReduce
                  org.apache.tajo.engine.function.TestConditionalExpressions
                  org.apache.tajo.engine.query.TestWindowQuery
                  org.apache.tajo.engine.planner.physical.TestSortExec
                  org.apache.tajo.engine.function.TestFunctionLoader
                  
org.apache.tajo.engine.function.TestStringOperatorsAndFunctions
                  org.apache.tajo.engine.query.TestAlterTable
                  org.apache.tajo.engine.query.TestCreateTable
                  org.apache.tajo.cli.tsql.TestTajoCli
                  org.apache.tajo.engine.query.TestUnionQuery
                  org.apache.tajo.engine.query.TestTableSubQuery
                  org.apache.tajo.engine.query.TestAlterTablespace
                  org.apache.tajo.engine.query.TestSetSessionQuery
                  org.apache.tajo.engine.query.TestJsonWithTimezone
                  org.apache.tajo.benchmark.TestTPCH
                  org.apache.tajo.engine.query.TestOuterJoinQuery
                  org.apache.tajo.engine.eval.TestSQLDateTimeTypes
                  org.apache.tajo.ws.rs.resources.TestQueryResultResource
                  org.apache.tajo.engine.query.TestInnerJoinWithSubQuery
                  org.apache.tajo.engine.eval.TestEvalTree
                  org.apache.tajo.engine.planner.TestQueryValidation
                  org.apache.tajo.cli.tsql.commands.TestExecExternalShellCommand
                  org.apache.tajo.engine.function.TestDateTimeFunctions
                  org.apache.tajo.engine.query.TestGroupByQuery
                  org.apache.tajo.engine.query.TestTimezone
                  org.apache.tajo.client.v2.TestTajoClientV2
                  org.apache.tajo.client.TestQueryClientExceptions
                  org.apache.tajo.ws.rs.resources.TestTablesResource
                  org.apache.tajo.ws.rs.resources.TestSessionsResource
                  org.apache.tajo.engine.query.TestTablePartitions
                  org.apache.tajo.cli.tools.TestTajoDump
                  org.apache.tajo.engine.query.TestSelectNestedRecord
                  org.apache.tajo.ws.rs.resources.TestClusterResource
                  org.apache.tajo.engine.query.TestCaseByCases
                  org.apache.tajo.engine.function.TestPatternMatchingPredicates
                  org.apache.tajo.client.TestTajoClient
                  org.apache.tajo.querymaster.TestTaskStatusUpdate
                  org.apache.tajo.querymaster.TestQueryState
                  org.apache.tajo.engine.query.TestInsertQuery
                  org.apache.tajo.engine.query.TestCTASQuery
                  org.apache.tajo.cli.tsql.TestDefaultCliOutputFormatter
                  org.apache.tajo.engine.eval.TestIntervalType
                  org.apache.tajo.ws.rs.resources.TestFunctionsResource
                  org.apache.tajo.engine.function.TestMathFunctions
                  org.apache.tajo.engine.query.TestHBaseTable
                  org.apache.tajo.engine.codegen.TestEvalCodeGenerator
                  org.apache.tajo.engine.query.TestSimpleQuery
                  org.apache.tajo.engine.query.TestQueryOnSelfDescTable
                  org.apache.tajo.engine.planner.TestPlannerUtil
                  org.apache.tajo.engine.query.TestCreateDatabase
                  org.apache.tajo.util.history.TestHistoryWriterReader
                  org.apache.tajo.querymaster.TestKillQuery
                  org.apache.tajo.engine.function.TestBuiltinFunctions
                  org.apache.tajo.engine.eval.TestPredicates
                  org.apache.tajo.engine.query.TestNullValues
                  org.apache.tajo.engine.function.TestPythonFunctions
                  org.apache.tajo.ws.rs.resources.TestQueryResource
                  org.apache.tajo.engine.query.TestOuterJoinWithSubQuery
                  org.apache.tajo.engine.query.TestNetTypes
                  org.apache.tajo.master.TestNonForwardQueryResultSystemScanner
                  org.apache.tajo.engine.query.TestIndexScan
                  org.apache.tajo.engine.query.TestSelectQuery
                  org.apache.tajo.engine.query.TestTruncateTable
                  org.apache.tajo.engine.eval.TestSQLExpression
                  org.apache.tajo.engine.query.TestCreateIndex
                  org.apache.tajo.engine.query.TestSortQuery
                  org.apache.tajo.engine.query.TestInSubquery
                  org.apache.tajo.engine.query.TestInnerJoinQuery
                  org.apache.tajo.querymaster.TestQueryProgress
                  org.apache.tajo.cli.tsql.TestTajoCliNegatives
                  org.apache.tajo.cli.tsql.commands.TestHdfsCommand
                  org.apache.tajo.engine.query.TestJoinOnPartitionedTables

Test results: 
https://builds.apache.org/job/PreCommit-TAJO-Build/895//testReport/
Findbugs results: 
https://builds.apache.org/job/PreCommit-TAJO-Build/895//findbugsResult
Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/895//console

This message is automatically generated.

> Improve hive compatibility with TIMESTAMP partition column.
> -----------------------------------------------------------
>
>                 Key: TAJO-1925
>                 URL: https://issues.apache.org/jira/browse/TAJO-1925
>             Project: Tajo
>          Issue Type: Improvement
>          Components: Catalog, Physical Operator
>    Affects Versions: 0.11.0, 0.12.0
>            Reporter: Jaehwa Jung
>            Assignee: Jaehwa Jung
>             Fix For: 0.12.0, 0.11.1
>
>         Attachments: TAJO-1925.patch
>
>
> -Currently, Tajo allow to use TIMESTAMP column as a partition key. But if 
> users use TIMESTAMP partition column, Tajo doesn't keep the original 
> TIMESTAMP values. Actually, Tajo automatically converts TIMESTAMP values to 
> STRING literals which are accepted in the format YYYY-MM-DD HH:MM:SS. As a 
> result, Tajo can't keep mills of second and can't provide right hive 
> compatibility-
> We need to support hive compatibility for all partition column types. But 
> when using TIMESTAMP partition column, users might not get correct partitions 
> occasionally because tajo partition name is different from hive partition 
> name. Actually, Tajo automatically converts TIMESTAMP values to STRING 
> literals which are accepted in the format YYYY-MM-DD HH:MM:SS. But Hive 
> automatically converts it to STRING literals which are accepted in the format 
> YYYY-MM-DD HH:MM:SS.MS. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to