Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/839#discussion_r44626380
--- Diff:
tajo-plan/src/main/java/org/apache/tajo/plan/logical/EvalExprNode.java ---
@@ -54,30 +54,30 @@ public boolean hasTargets() {
}
@Override
- public void setTargets(Target[] targets) {
+ public void setTargets(List<Target> targets) {
this.exprs = targets;
this.setOutSchema(PlannerUtil.targetToSchema(targets));
}
@Override
- public Target[] getTargets() {
+ public List<Target> getTargets() {
return exprs;
}
- public Target[] getExprs() {
+ public List<Target> getExprs() {
return this.exprs;
}
@Override
public String toString() {
- return "EvalExprNode (" + StringUtils.join(exprs) + ")";
+ return "EvalExprNode (" + StringUtils.join(exprs.toArray(new
Target[exprs.size()])) + ")";
--- End diff --
How about add a new ```join()``` method which takes a list of objects as
its parameter?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
