[ 
https://issues.apache.org/jira/browse/TAJO-1981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15010326#comment-15010326
 ] 

ASF GitHub Bot commented on TAJO-1981:
--------------------------------------

GitHub user jihoonson opened a pull request:

    https://github.com/apache/tajo/pull/865

    TAJO-1981: Invalid nulls sort order in VectorizedSorter

    I'm sorry for a large patch. Here are the highlights of this patch.
    * Fix the problem of invalid sort order of nulls in VectorizedSorter
    * Change the name of ```nullFirst``` variable to ```nullsFirst```
    * Change the string representation of ```SortSpec``` to print out the nulls 
order
    
    Most changes of this patch is due to the changed string representation of 
```SortSpec```, and there are only very minor changes.
    Please review this patch.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jihoonson/tajo-2 TAJO-1981

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tajo/pull/865.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #865
    
----
commit ee8a954164d6cb15641a4240ab00a885fa92ca6d
Author: Jihoon Son <[email protected]>
Date:   2015-11-18T03:32:40Z

    TAJO-1981

commit f17386a7b597ad07494587551b1a04ebbfc2dc6d
Author: Jihoon Son <[email protected]>
Date:   2015-11-18T05:14:30Z

    Fix query

commit 69bee13131616e1a2daabeac5b15287ec3ebe090
Author: Jihoon Son <[email protected]>
Date:   2015-11-18T06:13:41Z

    Fix test failures

----


> Invalid nulls sort order in VectorizedSorter
> --------------------------------------------
>
>                 Key: TAJO-1981
>                 URL: https://issues.apache.org/jira/browse/TAJO-1981
>             Project: Tajo
>          Issue Type: Bug
>          Components: Physical Operator
>            Reporter: Jihoon Son
>            Assignee: Jihoon Son
>             Fix For: 0.12.0, 0.11.1
>
>
> VectorizedSorter has the same problem with that reported in TAJO-1972.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to