[ 
https://issues.apache.org/jira/browse/TAJO-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15013267#comment-15013267
 ] 

ASF GitHub Bot commented on TAJO-1980:
--------------------------------------

Github user blrunner commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/863#discussion_r45320720
  
    --- Diff: 
tajo-core-tests/src/test/java/org/apache/tajo/cli/tsql/TestTajoCli.java ---
    @@ -561,4 +562,26 @@ public void printProgress(PrintWriter sout, 
QueryStatus status) {
           //nothing to do
         }
       }
    +
    +  @Test
    +  public void testDefaultPrintHelp() throws IOException, 
NoSuchMethodException {
    +    Iterator i = tajoCli.getContext().getCommands().keySet().iterator();
    --- End diff --
    
    If you use ```entrySet()``` instead of ```keySet().iterator()```, test 
codes would be more simple.


> Printout the usage of TajoShellCommand
> --------------------------------------
>
>                 Key: TAJO-1980
>                 URL: https://issues.apache.org/jira/browse/TAJO-1980
>             Project: Tajo
>          Issue Type: Bug
>            Reporter: Dongkyu Hwangbo
>            Assignee: Dongkyu Hwangbo
>            Priority: Trivial
>              Labels: cli, newbie
>
> TajoShellCommand::getUsage() is designed for TajoShellCommand::printHelp() to 
> printout detailed-usage like TajoShellCommand::getDescription(). But, 
> Currently, It's omitted in TajoShellCommand::printHelp(), so 
> TajoShellCommand::getUsage() has no usage.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to