[ 
https://issues.apache.org/jira/browse/TAJO-1855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15031477#comment-15031477
 ] 

ASF GitHub Bot commented on TAJO-1855:
--------------------------------------

Github user jihoonson commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/873#discussion_r46116563
  
    --- Diff: tajo-docs/src/main/sphinx/configuration/storage-site-json.rst ---
    @@ -0,0 +1,63 @@
    +**************************
    +The storage-site.json File
    +**************************
    +
    +This file is for configuring :doc:`/table_management/tablespaces`.
    +The syntax of ``storage-site.json`` is like this basically:
    +
    +.. code:: json
    +
    +  {
    +    "spaces": {
    +      <space config 1>, <space config 2>, ...
    +    },
    +    "storages": {
    +      <storage config 1>, <storage config 2>, ...
    +    }
    +  }
    +
    +------
    +Spaces
    +------
    +
    +This is a section for registering tablespaces. Some space config example 
is here:
    +
    +.. code:: json
    +
    +  "spaces": {
    +    "jdbc_pgsql": {
    +      "uri": "jdbc:postgresql://127.0.0.1:5740/origin",
    +      "configs": {
    +        "mapped_database":"tajo_pgsql_origin",
    +        "connection_properties": {
    +          "user":"tajouser",
    +          "password":"123456"
    +        }
    +      }
    +    },
    +    ...
    +  }
    +
    +* **space name** : Your own tablespace name which indicates a specific 
tablespace. Alpha-numeric characters and underscore(_) are permitted.
    +* **uri** : An URI address of a tablespace
    +* **configs** : It is optional. You can specify it as JSON object to pass 
to each tablespace handler.
    +
    +After you specify a tablespace, you can use it in `create table statement 
<../sql_language/ddl.html#create-table>`_.
    +
    +--------
    +Storages
    +--------
    +
    +This is for registering storage format and custom storage handler class.
    +Tajo already supports HDFS, HBase, PostgreSQL, Amazon S3, Openstack Swift, 
etc, thus in usual cases using mentioned storages, you don't have to use 
``storages`` configuration.
    --- End diff --
    
    I suggest ```you don't have to add any ``storages`` configuration.```


> Add document for tablespace configuration to the Configuration chapter.
> -----------------------------------------------------------------------
>
>                 Key: TAJO-1855
>                 URL: https://issues.apache.org/jira/browse/TAJO-1855
>             Project: Tajo
>          Issue Type: Sub-task
>          Components: Documentation
>            Reporter: Jihoon Son
>            Assignee: Jongyoung Park
>             Fix For: 0.11.1
>
>
> See the title.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to