[
https://issues.apache.org/jira/browse/TAJO-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15055258#comment-15055258
]
ASF GitHub Bot commented on TAJO-1990:
--------------------------------------
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/880#discussion_r47455815
--- Diff:
tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/HBaseTablespace.java
---
@@ -702,25 +705,22 @@ public String toString() {
@Nullable EvalNode
filterCondition)
throws IOException, MissingTablePropertyException,
InvalidTablePropertyException {
- List<IndexPredication> indexPredications = new ArrayList<>();
- Column[] indexableColumns = getIndexableColumns(tableDesc);
- if (indexableColumns != null && indexableColumns.length == 1) {
- // Currently supports only single index column.
- List<Set<EvalNode>> indexablePredicateList =
findIndexablePredicateSet(filterCondition, indexableColumns);
- for (Set<EvalNode> eachEvalSet: indexablePredicateList) {
- Pair<Datum, Datum> indexPredicationValues =
getIndexablePredicateValue(columnMapping, eachEvalSet);
- if (indexPredicationValues != null) {
- IndexPredication indexPredication = new IndexPredication();
- indexPredication.setColumn(indexableColumns[0]);
-
indexPredication.setColumnId(tableDesc.getLogicalSchema().getColumnId(indexableColumns[0].getQualifiedName()));
-
indexPredication.setStartValue(indexPredicationValues.getFirst());
-
indexPredication.setStopValue(indexPredicationValues.getSecond());
-
- indexPredications.add(indexPredication);
- }
- }
+ final Column[] indexableColumns = getIndexableColumns(tableDesc);
+ if (indexableColumns == null && indexableColumns.length == 0) {
--- End diff --
```&&``` needs to be ```||```.
> Refine some parts in HBaseTablespace.
> -------------------------------------
>
> Key: TAJO-1990
> URL: https://issues.apache.org/jira/browse/TAJO-1990
> Project: Tajo
> Issue Type: Improvement
> Components: HBase Storage
> Reporter: Hyunsik Choi
> Assignee: Hyunsik Choi
> Priority: Trivial
> Fix For: 0.12.0
>
>
> This is a trivial patch to refine some parts in HBaseTablespace.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
